minor changes for Batch #17 #4965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| @@ -214,7 +214,7 @@ public function run() { | |||
| * @return array | |||
| * (reference) of action links | |||
| */ | |||
| public function &links() { | |||
| static function &links() { | |||
There was a problem hiding this comment.
Should we do "public static function &links() {" ? The "public/private/protected" and "static" are independent of each other.
- "public/private/protected" specifies visibility. PHP won't generate warnings if these are omitted, but phpcs will.
- "static" indicates that the function will be called using class-notation. Old versions of PHP don't complain about this, but newer versions may complain with "Non-static method foo::bar() should not be called statically" if CRM_Contact_Page_View_UserDashBoard::links() calls a non-static function.
|
closing this PR because of extra commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix for Batch #17 (#4959)